Remove unused codecs and dependencies #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @nokome. Great to catch up with you today. I will bring this up with the rest of the team today. |
|
This looks great. We have been getting some value from the cli in development. But we know the cli is over-engineered when we only support the conversion of JATS to JSON now. I've submitted a PR to introduce a lightweight cli option which will reduce the feedback loop for us when developing support for things that aren't currently handled in Encoda. I will merge in the above once green. I've tested the script on master and this feature branch and it works and gives the same output. |
nlisgo
approved these changes
Oct 17, 2024
Remove all codecs not listed in `codecList` in `src/index.ts` or depended upon by those in there.
nokome
force-pushed
the
chore/remove-unused-deps
branch
from
b3d3972 to
08ac72a
Compare
|
I have rebased this on to current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some remaining opportunities for removing dependencies:
@stencila/jesta,get-stdinand other dependenices can be removed@stencila/loggawith use ofconsole.warnyamlcodec be removed (perhaps being used in tests)?