New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random value generation for pq.Float64Array factory #321

Merged

stephenafamo merged 2 commits into stephenafamo:main from felipeparaujo:main

Dec 9, 2024

Contributor

felipeparaujo commented Dec 5, 2024

The call to faker's f.Float64 method was missing parameters. I copied the ones set in this same file for non-array float64s.

To reproduce, create the following table and run bobgen-psql:

CREATE TABLE test (
  dbl_precision DOUBLE PRECISION [] NOT NULL
);

I couldn't find any tests for this behaviour, let me know if there are any that need updating.


          Fix random value generation for pq.Float64Array factory

5048ffe

Owner

stephenafamo commented Dec 5, 2024

Thank you. Also update CHANGELOG.md with details of this change under [Unreleased], along with attribution (thanks @felipeparaujo


          Update CHANGELOG.md

3c55a3c

stephenafamo merged commit 5487976 into stephenafamo:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet