Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net/netip to random expr imports #328

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

plunkettscott
Copy link
Contributor

The pgtypes.Inet type uses net/netip in its RandomExpr, but does not add it to the import list for the RandomExprImports. This results in a compilation error for the factory package if no other type exists which also imports the netip package.

I've worked around this in my projects by re-defining the type with the proper import until this can be merged.

@stephenafamo
Copy link
Owner

Kindly add a note in CHANGELOG.md with appropriate attribution (thanks @plunkettscott)

@plunkettscott
Copy link
Contributor Author

Done

@stephenafamo stephenafamo merged commit b263af1 into stephenafamo:main Dec 15, 2024
8 checks passed
@plunkettscott
Copy link
Contributor Author

Any estimate on when you plan to tag a release with this fix? Having to copy/paste a config across projects right now in the current state to avoid compilation errors.

@stephenafamo
Copy link
Owner

Tagged @plunkettscott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants