feat(Test): add sample for testing proto3 custom options #1133
Conversation
zakhenry
changed the title
| @@ -0,0 +1 @@ | |||
| outputExtensions=true,unknownFields=true,outputServices=generic-definitions,outputServices=default | |||
There was a problem hiding this comment.
I initially thought I could get this working with outputExtensions=true, but actually I suspect this needs to be an entirely new flag outputCustomOptions=true ?
|
wait this might just be #570. I'll sanity check myself then close if it's covered by that flag |
|
yea it is, whoops |
|
Np @zakhenry , good find that there is an existing issue for this -- re-reading that issue, sounds like there were some distractions/complications from the Granted, probably as part of its larger "schema for all your messages" output, but in theory it has code that reads the options, that could then be included in the grpc service definition output... If you'd like to make a PR for #570 that just always outputs options into the grpc service output (if I'm following along), that'd be great! Thanks! |
This PR is more of a request for comment - ts-proto doesn't yet support proto3 custom options (they are defined in proto2 docs, but are actually well supported in proto3). I've added a sample proto of the kinds of fields that can be used, and want to start discussion on how this might be incoporated into the ts-proto api (behind which flags etc)