Add support for assignment ops on class properties and dynamic array or queue elements #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsclausen
force-pushed
the
assignment-op
branch
4 times, most recently
from
3b1f505 to
0e915c9
Compare
Currently assignment operators on object properties are silently ignored. Make sure that they are handled. To enable this refactor the code a bit so that the assignment operator handling can be shared between object property assignments and scalar value assignments. Signed-off-by: Lars-Peter Clausen <[email protected]>
…ments Currently assignment operators on queues and dynamic elements trigger an assert. Add support for handling this properly. Since the operation for loading an element for an queue or dynamic array is identical most of the code can be shared, only writing back the value has to be handled separately. Signed-off-by: Lars-Peter Clausen <[email protected]>
Check that assignment operators are supported for class properties. Signed-off-by: Lars-Peter Clausen <[email protected]>
…ments Check that assignment operators work as expected on queue and dynamic array elements. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
force-pushed
the
assignment-op
branch
from
0e915c9 to
9f8a895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for assignment operators on class properties and dynamic array or queue elements. With a little bit of refactoring most of the code can be shared with the existing assignment operator support for scalars and arrays.