Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency #22

Open
wants to merge 3 commits into
base: 1.20-1.20.1
Choose a base branch
from

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Jan 18, 2025

Solve #21

@Wulian233
Copy link
Contributor Author

Reverted to 1.20-1.20.1. Tested on 1.20.6, the game failed to start. Mojang has made changes to the code used by Mixin

log

[21:40:36] [Render thread/ERROR]: Mixin apply for mod blinkload failed blinkload-common.mixins.json:client.texture.SpriteLoaderMixin from mod blinkload -> net.minecraft.class_7766: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on blinkload$loadAtlasTexturesFromCache could not find any targets matching 'Lnet/minecraft/class_7766;method_47661(Lnet/minecraft/class_3300;Lnet/minecraft/class_2960;ILjava/util/concurrent/Executor;)Ljava/util/concurrent/CompletableFuture;' in net/minecraft/class_7766. Using refmap blinkload-common-common-refmap.json [INJECT_PREPARE Applicator Phase -> blinkload-common.mixins.json:client.texture.SpriteLoaderMixin from mod blinkload -> Prepare Injections -> handler$zdf000$blinkload$loadAtlasTexturesFromCache(Lnet/minecraft/class_3300;Lnet/minecraft/class_2960;ILjava/util/concurrent/Executor;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse ->  -> Validate Targets]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on blinkload$loadAtlasTexturesFromCache could not find any targets matching 'Lnet/minecraft/class_7766;method_47661(Lnet/minecraft/class_3300;Lnet/minecraft/class_2960;ILjava/util/concurrent/Executor;)Ljava/util/concurrent/CompletableFuture;' in net/minecraft/class_7766. Using refmap blinkload-common-common-refmap.json [INJECT_PREPARE Applicator Phase -> blinkload-common.mixins.json:client.texture.SpriteLoaderMixin from mod blinkload -> Prepare Injections -> handler$zdf000$blinkload$loadAtlasTexturesFromCache(Lnet/minecraft/class_3300;Lnet/minecraft/class_2960;ILjava/util/concurrent/Executor;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse ->  -> Validate Targets]

@Steveplays28
Copy link
Member

Hi Wulian, thanks for testing that. I'll take a look at this later, I might drop 1.20 support alltogether, leaving only 1.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants