Cleanup code

src/main/java/com/stirante/runechanger/RuneChanger.java

@@ -262,13 +262,9 @@ public void onClientDisconnected() {
 
     private void onChampionChanged(Champion champion) {
         ObservableList<RunePage> pages = FXCollections.observableArrayList();
-        gui.setRunes(pages, (page) -> {
-            new Thread(() -> runesModule.setCurrentRunePage(page)).start();
-        });
+        gui.setRunes(pages, (page) -> new Thread(() -> runesModule.setCurrentRunePage(page)).start());
         log.info("Downloading runes for champion: " + champion.getName());
-        pages.addListener((InvalidationListener) observable -> {
-            gui.setRunes(pages);
-        });
+        pages.addListener((InvalidationListener) observable -> gui.setRunes(pages));
         RuneStore.getRunes(champion, pages);
     }
 

src/main/java/com/stirante/runechanger/client/ScreenPointChecker.java

@@ -79,6 +79,7 @@ public static void main(String[] args) throws InterruptedException {
         // Every second, we take screenshot and check if it matches the specified colors. Used for actually creating the screen points.
         // First, I take a screenshot of LoL client and then calculate percentage position of the point of interest.
         // After that, I check what color is there, when I want it to be triggered and then replace the values below, to check whether it triggers correctly
+        //noinspection InfiniteLoopStatement
         while (true) {
             BufferedImage screenshot = GDI32Util.getScreenshot(hwnd);
             float x = 0.1234375f;

src/main/java/com/stirante/runechanger/gui/ControllerUtil.java

@@ -3,14 +3,8 @@
 import com.jfoenix.controls.JFXAlert;
 import com.jfoenix.controls.JFXButton;
 import com.jfoenix.controls.JFXDialogLayout;
-import com.stirante.runechanger.util.LangHelper;
-import javafx.animation.FadeTransition;
-import javafx.fxml.FXMLLoader;
-import javafx.scene.Node;
 import javafx.scene.control.Label;
-import javafx.scene.layout.BorderPane;
 import javafx.stage.Modality;
-import javafx.util.Duration;
 
 import java.util.concurrent.atomic.AtomicBoolean;
 

src/main/java/com/stirante/runechanger/gui/Settings.java

@@ -29,7 +29,6 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.stream.Collectors;
 
 public class Settings extends Application {

src/main/java/com/stirante/runechanger/model/client/RunePage.java

@@ -261,13 +261,9 @@ public String toSerializedString() {
         runepageList.add(mainStyle);
         runepageList.add(subStyle);
 
-        runes.forEach(rune -> {
-            runepageList.add(rune.getId());
-        });
+        runes.forEach(rune -> runepageList.add(rune.getId()));
 
-        modifiers.forEach(modifier -> {
-            runepageList.add(modifier.getId());
-        });
+        modifiers.forEach(modifier -> runepageList.add(modifier.getId()));
 
         return runepageList.toString();
     }

src/main/java/com/stirante/runechanger/model/github/Version.java

@@ -21,8 +21,9 @@ public class Version {
             InputStream stream = Version.class.getResourceAsStream("/version.json");
             //Add our own date deserializer, which will return current date in case of parsing error
             //It's added, so it won't crash when running from IDE
-            JsonDeserializer<Date> dateDeserializer = new JsonDeserializer<Date>() {
+            JsonDeserializer<Date> dateDeserializer = new JsonDeserializer<>() {
                 DateFormat df = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ");
+
                 @Override
                 public Date deserialize(final JsonElement json, final Type typeOfT, final JsonDeserializationContext context)
                         throws JsonParseException {

src/main/java/com/stirante/runechanger/runestore/RuneSource.java

@@ -4,8 +4,6 @@
 import com.stirante.runechanger.model.client.RunePage;
 import javafx.collections.ObservableList;
 
-import java.util.List;
-
 public interface RuneSource {
 
     /**

src/main/java/com/stirante/runechanger/runestore/RuneStore.java

@@ -44,6 +44,7 @@ public static void getRemoteRunes(Champion champion, ObservableList<RunePage> pa
         }
     }
 
+    @SuppressWarnings("unchecked")
     public static <T extends RuneSource> T getSource(Class<T> clz) {
         for (RuneSource source : sources) {
             if (clz.isAssignableFrom(source.getClass())) {

src/main/java/com/stirante/runechanger/runestore/RuneforgeSource.java

@@ -4,7 +4,6 @@
 import com.stirante.runechanger.model.client.*;
 import com.stirante.runechanger.util.FxUtils;
 import com.stirante.runechanger.util.StringUtils;
-import generated.Position;
 import javafx.collections.ObservableList;
 import org.jsoup.Jsoup;
 import org.jsoup.nodes.Document;

src/main/java/com/stirante/runechanger/util/AutoUpdater.java

@@ -120,7 +120,7 @@ private static Configuration getConfiguration() throws IOException {
     private static void extractFile(ZipInputStream in, File outdir, String name) throws IOException {
         byte[] buffer = new byte[BUFFER_SIZE];
         BufferedOutputStream out = new BufferedOutputStream(new FileOutputStream(new File(outdir, name)));
-        int count = -1;
+        int count;
         while ((count = in.read(buffer)) != -1) {
             out.write(buffer, 0, count);
         }