Apply suggestions from code review

Co-authored-by: Peter Huene <[email protected]>
stjude-rust-labs · Dec 5, 2024 · 30861c9 · 30861c9
1 parent 801877a
commit 30861c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/wdl-lint/src/rules/container_value.rs b/wdl-lint/src/rules/container_value.rs
@@ -78,7 +78,7 @@ fn array_to_string_literal(span: Span) -> Diagnostic {
 /// Creates a diagnostic indicating that an array contains one or more 'any'
 /// URIs.
 fn array_containing_anys(spans: impl Iterator<Item = Span>) -> Diagnostic {
-    let mut diagnostic = Diagnostic::warning(String::from("arrays containing any are ambiguous"))
+    let mut diagnostic = Diagnostic::warning(format!("container arrays containing `{ANY_CONTAINER_VALUE}` are ambiguous"))
         .with_rule(ID)
         .with_fix(format!(
             "remove these entries or change the array to a string literal with the value of \

diff --git a/wdl-lint/src/rules/todo.rs b/wdl-lint/src/rules/todo.rs
@@ -32,7 +32,7 @@ fn todo_comment(comment: &str, comment_span: Span, offset: usize) -> Diagnostic
     Diagnostic::note(format!("remaining `{TODO}` item found"))
         .with_rule(ID)
         .with_highlight(Span::new(start, comment.len()))
-        .with_fix("remove the `TODO` item once it's been implemented")
+        .with_fix("remove the `TODO` item once it has been implemented")
 }
 
 impl Rule for TodoRule {