Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the string array functions from the WDL standard library. #255

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

peterhuene
Copy link
Collaborator

This PR implements the following functions from the WDL standard library:

  • prefix
  • suffix
  • quote
  • squote
  • sep

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

This commit implements the `prefix` function from the WDL standard library.

It also refactors out formatting a primitive value into a `raw` display method.
This commit implements the `suffix` function from the WDL standard library.
This commit implements the `quote` function from the WDL standard library.
This commit implements the `squote` function from the WDL standard library.
This commit implements the `sep` function from the WDL standard library.
Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@peterhuene peterhuene merged commit a208c01 into stjude-rust-labs:main Nov 20, 2024
16 checks passed
@peterhuene peterhuene deleted the stdlib branch November 20, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants