Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove trailing carriage return when stripping whitespace. #291

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

peterhuene
Copy link
Collaborator

This fixes whitespace stripping for both commands and multiline strings that left a trailing carriage return when using Windows line endings.

Also fixes the calculation of diagnostic spans for the preamble and version formatting lints when Windows line endings are used.

This should unblock PR #285.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

This fixes whitespace stripping for both commands and multiline strings that
left a trailing carriage return when using Windows line endings.

Also fixes the calculation of diagnostic spans for the preamble and version
formatting lints when Windows line endings are used.
@peterhuene peterhuene merged commit 0880d3f into stjude-rust-labs:main Jan 14, 2025
16 checks passed
@peterhuene peterhuene deleted the fix-strip-whitespace branch January 14, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants