fix: wdl run
should join input paths correctly.
#302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
wdl run
command to properly join input paths relative to the inputs file.The code to make the path of the inputs file absolute was incorrectly done, resulting in the later
join_paths
call to effectively be a no-op when the inputs file path on the command line was relative to CWD (e.g../foo.json
).As a result, task execution would fail when using the path as the path would then be treated as relative to the task's working directory as it was not made absolute.
The fix is to simply return the absolute path correctly from
parse_inputs
.Fixes #301.
Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md
(see"keep a changelog" for more information).