Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Ontology section #117

Merged
merged 16 commits into from
May 17, 2024
Merged

Updates to Ontology section #117

merged 16 commits into from
May 17, 2024

Conversation

Ssandor13
Copy link
Contributor

This PR adds a new St. Jude Cloud ontology section and revises the Metadata and Clinical section.

@Ssandor13 Ssandor13 requested a review from bgcurran May 7, 2024 19:51
@jamesmadson
Copy link
Collaborator

I had issues getting Node and Node-Sass working together, but I think this size of the image should work now.

@Ssandor13 Ssandor13 requested a review from DelaramR May 15, 2024 19:57
@DelaramR DelaramR requested a review from xuqiu5 May 15, 2024 20:01
DelaramR
DelaramR requested changes May 15, 2024
View reviewed changes
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
docs/genomics-platform/about-our-data/metadata-and-clinical/index.md Outdated Show resolved Hide resolved
src/config/docs.yaml Outdated Show resolved Hide resolved
@Ssandor13
Copy link
Contributor Author

@DelaramR @bgcurran thank you for the review. All changes have been updated including updating the YAML file to name it disease-ontology ; great feedback @DelaramR.

DelaramR
DelaramR approved these changes May 16, 2024
View reviewed changes
Copy link

@DelaramR DelaramR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ssandor13 and @bgcurran

@Ssandor13 Ssandor13 merged commit a2df0aa into master May 17, 2024
1 check failed
@Ssandor13 Ssandor13 deleted the Update_to_add_ontology branch May 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgcurran bgcurran bgcurran left review comments

@DelaramR DelaramR DelaramR approved these changes

@xuqiu5 xuqiu5 Awaiting requested review from xuqiu5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ssandor13 @jamesmadson @DelaramR @bgcurran