-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build and test #210
ci: build and test #210
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
runs-on: ubuntu-latest | ||
if: ${{ github.event.workflow_run.conclusion == 'failure' }} | ||
steps: | ||
- run: echo 'The build workflow failed, skipping tests' && exit 1 | ||
list-tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's important, but I wonder if the tag list could be passed between the workflows. It's cheap to recompute, so it's more a curiosity.
@@ -92,9 +92,11 @@ jobs: | |||
image: ${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.TOOL }}:local | |||
args: --file=${{ matrix.image }}/Dockerfile | |||
- name: Clean Snyk SARIF file | |||
continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on both of these. Definitely the preferred behavior.
Describe the problem or feature in addition to a link to the issues.
Fixes the CI for the hundredth time this week (and hopefully the last time).
Before submitting this PR, please make sure:
scripts/
ordocker/
directories, please ensure any image versions have been incremented accordingly!