Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build and test #210

Merged
merged 5 commits into from
Jan 31, 2025
Merged

ci: build and test #210

merged 5 commits into from
Jan 31, 2025

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Jan 31, 2025

Describe the problem or feature in addition to a link to the issues.

Fixes the CI for the hundredth time this week (and hopefully the last time).

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • The code passes all CI tests without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in any relevant CHANGELOGs (when appropriate).
  • If you have made any changes to the scripts/ or docker/ directories, please ensure any image versions have been incremented accordingly!
  • You have updated the README or other documentation to account for these changes (when appropriate).

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'failure' }}
steps:
- run: echo 'The build workflow failed, skipping tests' && exit 1
list-tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's important, but I wonder if the tag list could be passed between the workflows. It's cheap to recompute, so it's more a curiosity.

@a-frantz a-frantz marked this pull request as ready for review January 31, 2025 15:47
@@ -92,9 +92,11 @@ jobs:
image: ${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.TOOL }}:local
args: --file=${{ matrix.image }}/Dockerfile
- name: Clean Snyk SARIF file
continue-on-error: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on both of these. Definitely the preferred behavior.

@a-frantz a-frantz merged commit d03b6e1 into main Jan 31, 2025
42 checks passed
@a-frantz a-frantz deleted the ci/build-and-test branch January 31, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants