Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testValid last test case fails in default strictmode test runs #940

Closed
stleary opened this issue Jan 12, 2025 · 2 comments
Closed

testValid last test case fails in default strictmode test runs #940

stleary opened this issue Jan 12, 2025 · 2 comments

Comments

@stleary
Copy link
Owner

stleary commented Jan 12, 2025

Part of testing strictMode code is to set the default strictMode to true in JSONParserConfiguration. Then the entire suite of tests can be executed using mvn compile test or gradlew build test to ensure that strictMode does not break existing functionality. Certain tests are skipped by checking the default strictMode setting, due to the particular details in the tests.

The JSONTokenerTest testValid() test case fails in the last check for String "1 2". This case should be skipped when strictMode defaults to true.

Note: 2 recently added tests in JSONTokenerTest are failing default strictMode, and should also be fixed.

@stleary
Copy link
Owner Author

stleary commented Jan 12, 2025

@clivinn-shla81092 Thanks, I appreciate the attempt, and contributions from LLMs are always welcome, but the "default strictMode" test run requires a local change to the strictMode default, and should never be committed. Also I think you broke the code by removing some closing braces. But the code update to testValid() looks spot-on. Better luck next time.

@stleary
Copy link
Owner Author

stleary commented Feb 15, 2025

Closed due to fixed in #951

@stleary stleary closed this as completed Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@stleary and others