Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing and updating unit tests for default strictMode #951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marilynel
Copy link
Contributor

@marilynel marilynel commented Feb 15, 2025

Fixes issue #940
Note: A poorly written test in JSONObjectTest will be handled in a separate issue

@stleary stleary changed the title #940 unit tests Fixing and updating unit tests for default strictMode Feb 15, 2025
@stleary
Copy link
Owner

stleary commented Feb 15, 2025

What problem does this code solve?
Fixes several failed unit tests when default strictMode is true.
Also refactored existing tests that were just skipped in strictMode.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, the unit tests were updated.

Was any code refactored in this commit?
Some unit tests were refactored

Review status
APPROVED

Starting 3-day comment window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants