-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add I2S communication using SPI peripherals #265
Conversation
I tested this on the Stm32F407G-DISC1 and it seems to work fine there as well. |
Works for me on my STM32F407G-DISC1 too. The only not I'd have is to lower the volume down to -100. The current one blasted my ears. Thanks a lot for this patch @samcrow, I was struggling to get I2S work on my board for a while. |
The previous commit failed many checks because of an unrelated problem with the dependency `cast`. Now that that has been fixed, this should make the checks succeed.
…es are enabled more consistently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent. Let's get that in now.
bors r+
Introduction
Welcome to my first large pull request, which adds support for I2S audio communication using supported SPI peripherals. Like the way we support CAN with the bxcan library, I am proposing to support I2S using my stm32_i2s_v12x library.
Although stm32_i2s_v12x is in a separate repository, we can also talk about it here.
Notes
i2s
feature is enabled, in order to not increase compile time for applications that don't use I2S.These changes are not perfect, so criticism and suggestions are welcome.
Limitations
Related work