fix: provide default source directories for packages #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymtszw
commented
Feb 13, 2024
| @@ -232,7 +232,7 @@ function elmPathToModule(elmRoot, sourceDirs, testsPath) { | |||
| }; | |||
| } | |||
|
|
|||
| function findModule(elmRoot, sourceDirs, pathName) { | |||
| function findModule(elmRoot, sourceDirs = ["./src"], pathName) { | |||
There was a problem hiding this comment.
findModule() is called in a manner of findModule(root, model["source-directories"], pathName), which leads to nullish referencing inside the function in case of package Elm project.
I've chosen the path of adding fallback sourceDirs for minimal impact/low friction in mind.
stoeffel
added a commit
that referenced
this pull request
Feb 13, 2024
fix: provide default source directories for packages
|
Published with 6.0.3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112, with minimal impact on other places (at least I think so)