Report manifestworks first applied timestamp #215
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zhujian7
changed the title
|
/test unit |
|
depends on stolostron/backplane-operator#1175 |
zhujian7
changed the title
|
/assign @qiujian16 @elgnay |
|
/hold |
zhujian7
force-pushed
the
generation-applied-time
branch
from
5ab3805 to
a3d247a
Compare
|
/test unit |
1 similar comment
|
/test unit |
zhujian7
force-pushed
the
generation-applied-time
branch
from
48d2dd3 to
e074263
Compare
zhujian7
force-pushed
the
generation-applied-time
branch
2 times, most recently
from
449d424 to
91f6ad2
Compare
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
generation-applied-time
branch
from
91f6ad2 to
dea74c8
Compare
|
/cc @haoqing0110 |
|
/hold cancel |
pkg/options/options.go
Outdated
| flag.BoolVar(&o.EnableLeaderElection, "leader-elect", true, | ||
| "Enable leader election for controller manager. "+ | ||
| "Enabling this will ensure there is only one active controller manager.") | ||
| // set default "0" to disable the controller metrics, otherwise the the default 8080 port will conflict. |
There was a problem hiding this comment.
When I first read the comments, I was not sure the 8080 port would conflict with what? Can we clarity that there are 2 ports, the new controller's metrics default port 8080 and the clusterlifecycle-state-metrics server's port 8080, and they will have a conflict? when the comments said "metrics endpoint" it's a little confusing.
|
/approve |
Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
generation-applied-time
branch
from
cf78cd9 to
ee01ec3
Compare
|
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, haoqing0110, qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "Red Hat Konflux / Red Hat Konflux / mce-28-enterprise-contract-registry-standard / clusterlifecycle-state-metrics-mce-28" |
|
@zhujian7: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / clusterlifecycle-state-metrics-mce-28" |
|
@zhujian7: Overrode contexts on behalf of zhujian7: Red Hat Konflux / mce-28-enterprise-contract-registry-standard / clusterlifecycle-state-metrics-mce-28 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 4192e97
into
stolostron:main
depends on: stolostron/backplane-operator#1175
issue reference: https://issues.redhat.com/browse/ACM-16796
This PR will start a manifestwork controller to watch manifestworks with any of 3 labels, and record the lastTranstionTime of the Applied condition as an annotation.
In the other side the manifestwork metric collector will report the recorded time as the manifestwork observed first applied time metric.