Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-14718: Render internal line breaks in hive's ProvisionFailed status condition message #4235

Conversation

nitin-dhevar
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Nitin Dhevar <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Nitin Dhevar <[email protected]>
Comment on lines 131 to 132
if (messageArray.length > 9) {
message = `${messageArray.slice(0, 8).join('\n')}...`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a slight off-by-one error here. Other than that, it looks great. Good job.

Signed-off-by: Nitin Dhevar <[email protected]>
@KevinFCormier
Copy link
Contributor

/lgtm

@KevinFCormier
Copy link
Contributor

/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213"

Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, nitin-dhevar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 30, 2025

@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213

In response to this:

/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@KevinFCormier
Copy link
Contributor

/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28"

Copy link

openshift-ci bot commented Jan 30, 2025

@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28

In response to this:

/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 947d8b2 into stolostron:main Jan 30, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants