-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-14718: Render internal line breaks in hive's ProvisionFailed status condition message #4235
ACM-14718: Render internal line breaks in hive's ProvisionFailed status condition message #4235
Conversation
Signed-off-by: Nitin Dhevar <[email protected]>
Signed-off-by: Nitin Dhevar <[email protected]>
if (messageArray.length > 9) { | ||
message = `${messageArray.slice(0, 8).join('\n')}...` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a slight off-by-one error here. Other than that, it looks great. Good job.
Signed-off-by: Nitin Dhevar <[email protected]>
|
/lgtm |
/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213" |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, nitin-dhevar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28" |
@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
947d8b2
into
stolostron:main
No description provided.