Accessibility: Required form fields should use default message not 'R…

…equired' #768430
stopfstedt · May 20, 2024 · 8c4042a · 8c4042a
1 parent 8f14d1e
commit 8c4042a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/comment_form.php b/comment_form.php
@@ -52,7 +52,7 @@ public function definition() {
             $mform->addElement('text', 'authorname',
                     get_string('moderated_authorname', 'oublog'), 'size="48"');
             $mform->setType('authorname', PARAM_TEXT);
-            $mform->addRule('authorname', get_string('required'), 'required', null, 'client');
+            $mform->addRule('authorname', null, 'required', null, 'client');
         }
 
         $mform->addElement('text', 'title', get_string('title', 'oublog'), 'size="48"');
@@ -67,7 +67,7 @@ public function definition() {
                 array('cols' => 50, 'rows' => 30),
                 array('maxfiles' => EDITOR_UNLIMITED_FILES, 'maxbytes' => $maxbytes));
         $mform->setType('messagecomment', PARAM_CLEANHTML);
-        $mform->addRule('messagecomment', get_string('required'), 'required', null, 'server');
+        $mform->addRule('messagecomment', null, 'required', null, 'server');
 
         // When using moderation, we include the world's dumbest capcha (the
         // user is told to type 'yes' into the box). Because there is moderation

diff --git a/link_form.php b/link_form.php
@@ -29,11 +29,11 @@ public function definition() {
 
         $mform->addElement('text', 'title', get_string('title', 'oublog'), 'size="48"');
         $mform->setType('title', PARAM_TEXT);
-        $mform->addRule('title', get_string('required'), 'required', null, 'client');
+        $mform->addRule('title', null, 'required', null, 'client');
 
         $mform->addElement('text', 'url', get_string('url', 'oublog'), 'size="48"');
         $mform->setType('url', PARAM_URL);
-        $mform->addRule('url', get_string('required'), 'required', null, 'client');
+        $mform->addRule('url', null, 'required', null, 'client');
 
         if ($edit) {
             $submitstring = get_string('savechanges');
@@ -57,4 +57,4 @@ public function definition() {
         $mform->setType('cmid', PARAM_INT);
 
     }
-}
+}
diff --git a/post_form.php b/post_form.php
@@ -64,7 +64,7 @@ public function definition() {
         $mform->addElement('editor', 'message', get_string('message', 'oublog'),
                 array('cols' => 50, 'rows' => 30),
                 array('maxfiles' => EDITOR_UNLIMITED_FILES, 'maxbytes' => $maxbytes));
-        $mform->addRule('message', get_string('required'), 'required', null, 'client');
+        $mform->addRule('message', null, 'required', null, 'client');
 
         if ($this->restricttags) {
             $mform->addElement('static', 'restricttagswarning', '', get_string('restricttagslist', 'oublog', implode(',', $atags)));
@@ -77,7 +77,7 @@ public function definition() {
             $mform->setDefault('tags', $tagslist);
         }
         if ($this->requiretags) {
-            $mform->addRule('tags', get_string('required'), 'required', null, 'client');
+            $mform->addRule('tags', null, 'required', null, 'client');
         }
 
         $options = array();