Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add useful utilities to the chain docker images #307

Merged
merged 2 commits into from
Jan 9, 2025
Merged

feat: add useful utilities to the chain docker images #307

merged 2 commits into from
Jan 9, 2025

Conversation

Zak4sad
Copy link
Contributor

@Zak4sad Zak4sad commented Jan 8, 2025 •
edited
Loading

This PR is for adding useful utilities to the chain docker images ( mkdir, vi, rm and mv)

Ref: 301

Changes:

  • Install / Enable necessary applet
    • rm (for cleanup)
    • mv (for moving / renaming files)
    • mkdir (for creating directories)
    • vi (for editing files')
  • Prevent those write utils from being removed

Tests:

  • While preparing the test, I grouped the chains into 4 categories :
    • avalanche
    • cargo
    • cosmos
    • imported
  • And for each of those categories , I had to run a test.
    • avalanche
      • Chain: avalanche
      • Image: ghcr.io/strangelove-ventures/heighliner/avalanche:v1.11.11-utility
image
  • cargo
    • Chain: neutron
    • Image: ghcr.io/strangelove-ventures/heighliner/neutron:v5.0.5-utility
image

  • cosmos

    • Chain: sei

  • Imported

    • Chain: union
    • Image: ghcr.io/strangelove-ventures/heighliner/union:v0.24.0-utility
image

Author Checklist

  • Updated PR status in SL Platform Project

@Zak4sad Zak4sad self-assigned this Jan 8, 2025
nourspace
nourspace approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@nourspace nourspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the thorough tests.

@Zak4sad
Copy link
Contributor Author

Zak4sad commented Jan 9, 2025

aria2c (download utility that supports HTTP and FTP) will be added in a separate PR here strangelove-ventures/infra-toolkit#18

@Zak4sad Zak4sad merged commit 349c57c into main Jan 9, 2025
7 checks passed
@Zak4sad Zak4sad deleted the zasadek/feat/301-add-useful-utilities branch January 9, 2025 15:13
@Zak4sad Zak4sad linked an issue Jan 9, 2025 that may be closed by this pull request
Images missing rm #301
Closed
@Zak4sad Zak4sad mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nourspace nourspace nourspace approved these changes

Assignees

@Zak4sad Zak4sad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images missing rm
2 participants
@Zak4sad @nourspace