Downgrade DM debugging messages to trace level #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
approved these changes
Nov 8, 2023
src/core/dm.rs
Outdated
| @@ -586,7 +586,7 @@ impl DM { | |||
| pub fn table_clear(&self, id: &DevId<'_>) -> DmResult<DeviceInfo> { | |||
| let mut hdr = DmOptions::default().to_ioctl_hdr(Some(id), DmFlags::empty())?; | |||
|
|
|||
| debug!("Clearing inactive dable for {}", id); | |||
| trace!("Clearing inactive dable for {}", id); | |||
There was a problem hiding this comment.
Might as well fix typo also: ^dable^table
mulkieran
requested changes
Nov 8, 2023
bmr-cymru
force-pushed
the
bmr-quiet-dm-debug-logging
branch
from
9753e33 to
8480103
Compare
jbaublitz
approved these changes
Nov 8, 2023
I think that would make sense. Those operations should be considerably less frequent in any case. I'll update the PR. |
Commit 66e1fdf added logging to the DM module using the debug! macro. In practice these messages can be very noisy, especially for e.g. in the Stratis test suite (which calls the status() method on thin pool devices). This leads to lots of messages like the following: [2023-11-06T16:01:05Z DEBUG devicemapper::core::dm] Retrieving table status for stratis-1-private-50db9929d265403b820bb155c8f5ae89-thinpool-pool Running the Stratis test suite results in hundreds of these messages being logged at debug level. Downgrade the logging calls in the DM module from debug! to trace! to quiet this down.
bmr-cymru
force-pushed
the
bmr-quiet-dm-debug-logging
branch
from
8480103 to
ef2697e
Compare
|
I've revised this to leave the create, remove, rename, suspend/resume and target message logs at debug level with the rest downgraded to trace. |
mulkieran
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 66e1fdf added logging to the DM module using the debug! macro.
In practice these messages can be very noisy, especially for e.g. in the Stratis test suite (which calls the status() method on thin pool devices). This leads to lots of messages like the following:
[2023-11-06T16:01:05Z DEBUG devicemapper::core::dm] Retrieving table status for stratis-1-private-50db9929d265403b820bb155c8f5ae89-thinpool-pool
Running the Stratis test suite results in hundreds of these messages being logged at debug level.
Downgrade the logging calls in the DM module from debug! to trace! to quiet this down.