Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust 1.83 clippy errors #383

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

bgurney-rh
Copy link
Member

Signed-off-by: Bryan Gurney <[email protected]>
@bgurney-rh bgurney-rh self-assigned this Dec 2, 2024
@bgurney-rh
Copy link
Member Author

I believe this is blocked by a change that's needed via jbaublitz/per-thread-mutex#11.

@bgurney-rh bgurney-rh marked this pull request as ready for review December 2, 2024 19:25
@bgurney-rh
Copy link
Member Author

OK, I think this is ready.

Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really want to bump the mutex dependency except on a version update. Try the following patch instead:

diff --git a/src/lib.rs b/src/lib.rs
index bee3a6b8..0679ad57 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -31,6 +31,7 @@ mod keyslot;
 mod log;
 mod luks2;
 mod mem;
+#[allow(clippy::all)]
 #[cfg(feature = "mutex")]
 mod mutex;
 mod runtime;

@bgurney-rh
Copy link
Member Author

OK, that works. I'm dropping the submodule patch, and adding this update to src/lib.rs.

@mulkieran mulkieran merged commit ad30fec into stratis-storage:master Dec 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done(1)
Development

Successfully merging this pull request may close these issues.

2 participants