Clean up crypt module in preparation for metadata rework #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
force-pushed
the
crypt-clean-up
branch
2 times, most recently
from
d51e84c to
13db008
Compare
This commit aims to make the crypt layer look a little bit more like our other devicemapper layers in service of simplifying our metadata rework. This will allow us to factor out a large amount of shared code between the crypt header used to encrypt the pool level metadata and the crypt header used to encrypt the data.
jbaublitz
force-pushed
the
crypt-clean-up
branch
from
6b27063 to
e547611
Compare
mulkieran
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3274