Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase libcryptsetup-rs, libcryptsetup-rs-sys, and devicemapper dependency lower bounds #3474

Merged

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 23, 2023

@mulkieran mulkieran self-assigned this Oct 23, 2023
@mulkieran mulkieran requested a review from bgurney-rh October 23, 2023 19:53
@mulkieran mulkieran marked this pull request as ready for review October 23, 2023 19:53
@mulkieran
Copy link
Member Author

mulkieran commented Oct 23, 2023

rpms are failing to build because of dependencies missing. This will continue until we release. We'll delay merging this until devicemapper release is also out.

@mulkieran mulkieran force-pushed the libcryptsetup-rs-sys-v0.3.0 branch from 1a25e9c to b71f944 Compare October 23, 2023 23:19
@mulkieran mulkieran force-pushed the libcryptsetup-rs-sys-v0.3.0 branch from 12b303b to efcd2fd Compare October 24, 2023 00:15
@mulkieran mulkieran changed the title Libcryptsetup rs sys v0.3.0 Increase libcryptsetup-rs, libcryptsetup-rs-sys, and devicemapper dependency lower bounds Oct 24, 2023
Copy link
Member

@bgurney-rh bgurney-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a mock build of efcd2fd for centos 9 stream succeeds, with this output during vendoring:

   Compiling devicemapper-sys v0.2.0
   Compiling devicemapper v0.34.0

   Compiling libcryptsetup-rs-sys v0.3.0
   Compiling libcryptsetup-rs v0.9.1

   Compiling libblkid-rs-sys v0.2.0
   Compiling libblkid-rs v0.3.1

@mulkieran
Copy link
Member Author

Ok!

@mulkieran mulkieran merged commit 58fbded into stratis-storage:master Oct 24, 2023
37 of 41 checks passed
@mulkieran mulkieran deleted the libcryptsetup-rs-sys-v0.3.0 branch October 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants