Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bandit and pyright checks to test code #3666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Aug 8, 2024

@mulkieran mulkieran self-assigned this Aug 8, 2024
@mulkieran
Copy link
Member Author

Also pyright...

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3666
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the bandit branch 2 times, most recently from 8347f55 to a566169 Compare January 7, 2025 02:09
@mulkieran mulkieran changed the title Add bandit checks to test code Add bandit and pyright checks to test code Jan 7, 2025
@mulkieran mulkieran force-pushed the bandit branch 3 times, most recently from f819982 to 3541a7d Compare January 7, 2025 17:38
Use tenacity where it is useful to fix pyright and bandit errors.

Change pylint target to lint target in top level Makefile, since the
target also includes using bandit and pyright.

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran marked this pull request as ready for review January 7, 2025 20:27
@mulkieran mulkieran requested a review from jbaublitz January 7, 2025 20:28
@mulkieran
Copy link
Member Author

@jbaublitz No need to check the code, but once this is merged you'll need to have bandit (from Fedora) and pyright (from pip) installed in order to run the git commit hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant