Snapshot support #3694
Merged
Snapshot support #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
We expect all tests to pass |
mulkieran
force-pushed
the
snapshot-support
branch
2 times, most recently
from
5a5b21d to
6806499
Compare
|
Previous test failure was due to nothing worse than a missing chunk of test... |
mulkieran
force-pushed
the
snapshot-support
branch
from
6806499 to
635f690
Compare
|
Failing tests were caused by PoolStart call with extra fd in Python test code... |
mulkieran
force-pushed
the
snapshot-support
branch
2 times, most recently
from
5e3b985 to
479f2ec
Compare
|
Squashed to eliminate some switchbacks |
jbaublitz
reviewed
Oct 1, 2024
|
@jbaublitz back at you... |
jbaublitz
requested changes
Oct 2, 2024
|
@jbaublitz I decided to inline all the format strings that I could inline that were introduced by this PR. |
|
@jbaublitz Ok. This is ready again. |
jbaublitz
approved these changes
Oct 3, 2024
bmr-cymru
approved these changes
Oct 3, 2024
mulkieran
force-pushed
the
snapshot-support
branch
from
e060d83 to
7047c31
Compare
|
squashed... |
Add MergeRequested property to filesystem D-Bus interface. Use it to set and unset the filesystem metadata field. Change destroy_filesystems to take into account the merge status of a filesystem. Move all the destroy functionality into thinpool implementation. Do more checks to avoid deleting filesystems that shouldn't be deleted. Check for situations where multiple snapshots are referring to the same deleted filesystem. Check for invalid scheduling requests when requesting or canceling a merge request. Add merge field to SimFilesystem's metadata for completeness' sake. Add some tests. Signed-off-by: mulhern <[email protected]>
Verify that scheduled merges are permissible. Return with an error without setting up any filesystems if duplicate UUIDs or names are found. Perform the merges before setting up any filesystems. If a merge can be rolled back, set up the two filesystems in the merge relation in the normal way. Also set the reverted filesystem UUID to the origin's UUID. After a revert has completed, patch up origin links. Set a snapshot of the reverted snapshot to that snapshot's origin. When reverting one snap, A into another snap, B, the reverted filesystem should have B's origin. Define a merge operation for the FilesystemSave struct. Signed-off-by: mulhern <[email protected]>
Semantics preserving, so pass None where it is invoked. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Make this change visible on the D-Bus. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
snapshot-support
branch
2 times, most recently
from
11af265 to
45fed6c
Compare
|
Gating tests and stratis-cli tests will fail... |
|
Only gating tests fail... |
Signed-off-by: mulhern <[email protected]>
|
Gating tests should no longer fail... |
|
TMT is stuck on Cockpit tests, merging... |
mulkieran
merged commit 326ae2e
into
stratis-storage:rebase-3.6.0
49 of 50 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.