Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better error message on Clevis unlock failure #3741

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jbaublitz
Copy link
Member

This PR fixes a bug in our clevis decrypt command where it reported success in failure cases and also provides better error messages to the user when the failure occurs.

cc @martinpitt

@jbaublitz
Copy link
Member Author

Example error message:

Execution failed:
stratisd failed to perform the operation that you requested. It returned the following information via the D-Bus: ERROR: An attempt to set up pool with UUID e94a3e25-229a-4752-8715-c97cae0fdd75 from the assembled devices failed; Failed to unlock using token; Failed to retrieve Clevis passphrase; Error communicating with server localhost. 

@jbaublitz jbaublitz force-pushed the bugzilla branch 2 times, most recently from 7aec887 to 7b19bc0 Compare January 8, 2025 01:34
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3741
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jbaublitz jbaublitz marked this pull request as draft January 8, 2025 01:43
@martinpitt
Copy link
Contributor

Thanks @jbaublitz!

This commit fixes a bug in our clevis_decrypt function where it would
report success even on failure. It also provides a better error message
on failure to the user.
@jbaublitz jbaublitz marked this pull request as ready for review January 8, 2025 23:34
@mulkieran mulkieran merged commit 5654874 into stratis-storage:master Jan 9, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants