Fix clippy 1.84 linting errors #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
mulkieran
requested changes
Jan 9, 2025
src/dbus_api/tree.rs
Outdated
| @@ -298,7 +298,8 @@ impl DbusTreeHandler { | |||
| opath | |||
| .get_data() | |||
| .as_ref() | |||
| .map_or(false, |op_cxt| op_cxt.parent == item) | |||
| .as_ref() | |||
There was a problem hiding this comment.
I suspect the second as_ref() was unintentional.
There was a problem hiding this comment.
Whoops; I had a "make fmt" fix to make on that line, after this, so it probably masked this. Fixed now.
Signed-off-by: Bryan Gurney <[email protected]>
bgurney-rh
force-pushed
the
clippy-1.84
branch
from
92276b7 to
66d3066
Compare
mulkieran
approved these changes
Jan 9, 2025
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Packit is having some coordination problems. Given the unsuspicious nature of this PR + all non-TMT tests passing, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: stratis-storage/project#747