Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variables.tf #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update variables.tf #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/aws/vendor-access/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ variable "external_id" {
default = ""
description = "A external ID that correspond to your Organization within StreamNative Cloud, used for all STS assume role calls to the IAM roles created by the module. This will be the organization ID in the StreamNative console, e.g. \"o-xhopj\"."
type = string

validation {
condition = var.external_id == "" || can(regex("^o-", var.external_id))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi, @tendhar33 Very appreciate for your PR!

However we're unable to add the validation here since the StreamNative Cloud BYOC Pro customer can customize the Organization ID which can be any string.

Can I know what errors you encountered during using this module so we can have more accurate improvements? Thanks.

error_message = "The external_id must either be empty or start with 'o-'. For example: 'o-xhopj'."
}
}

variable "external_ids" {
Expand Down