refactor: .sarif now builds conditionally onlly

stride3d · May 29, 2024 · 2a7d0f4 · 2a7d0f4
1 parent 0a64c13
commit 2a7d0f4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/dotnet-nuget.yml b/.github/workflows/dotnet-nuget.yml
@@ -29,9 +29,10 @@ jobs:
         $updatedCsprojContent = $settingsContent -replace '<Version>.*?</Version>', "<Version>${{ env.VERSION }}</Version>"
         Set-Content -Path ${{ env.COMMON_SETTINGS_PATH }} -Value $updatedCsprojContent
 
-    - name: Create .sarif Directory
-      run: New-Item -ItemType Directory -Force -Path D:\.sarif
-      shell: pwsh           
+    # Not needed as Directory.Build.props added a condition to this target
+    # - name: Create .sarif Directory
+    #   run: New-Item -ItemType Directory -Force -Path D:\.sarif
+    #   shell: pwsh
 
     # Stride.CommunityToolkit
     - name: Restore dependencies - Stride.CommunityToolkit

diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -21,9 +21,10 @@ jobs:
       with:
         dotnet-version: 8.0.x
 
-    - name: Create .sarif Directory
-      run: New-Item -ItemType Directory -Force -Path D:\.sarif
-      shell: pwsh        
+    # Not needed as Directory.Build.props added a condition to this target
+    # - name: Create .sarif Directory
+    #   run: New-Item -ItemType Directory -Force -Path D:\.sarif
+    #   shell: pwsh
 
     # Stride.CommunityToolkit
     - name: Restore Stride.CommunityToolkit dependencies

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,5 +1,5 @@
 <Project>
-  <PropertyGroup>
+  <PropertyGroup Condition="'$(SolutionDir)' != ''">
     <ErrorLog>$(SolutionDir)\.sarif\$(MSBuildProjectName).json</ErrorLog>
   </PropertyGroup>
 </Project>