Add support for Strimzi Metrics Reporter #954
Open
+828
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
reviewed
Dec 17, 2024
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
a211d27 to
9385323
Compare
scholzj
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I wonder if this should go through a dedicated proposal first. The original proposal - https://github.com/strimzi/proposals/blob/main/064-prometheus-metrics-reporter.md - sadly didn't cover the bridge in sufficient depth and there will be some backward compatibility impact here or in the operators repo that needs to be carefully considered. A proposal would be the right place to discuss it and decide on the best approach.
I agree. @ppatierno wdyt? |
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
4a47979 to
4d87ff9
Compare
ppatierno
reviewed
Dec 20, 2024
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
4d87ff9 to
8b9e345
Compare
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
8b9e345 to
d0eedcd
Compare
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
ddabfb1 to
5084403
Compare
fvaleri
changed the title
fvaleri
changed the title
This patch adds support for metrics types configuration, integrating the Strimzi Metrics Reporter, and custom Prometheus JMX Exporter configuration. The custom configuration feature is needed for Cluster Operator integration, but it can also be leveraged by standalone users. See Proposal 43 for more details. Signed-off-by: Federico Valeri <[email protected]>
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
395ceda to
01d1b74
Compare
|
@strimzi/maintainers proposal 92 has been accepted, and this PR is aligned, so open for review. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for metrics types configuration, integrating the Strimzi Metrics Reporter), and custom Prometheus JMX Exporter configuration. The custom configuration feature is needed for Cluster Operator integration, but it can also be leveraged by standalone users. See proposal 43 for more details.