Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kafka and ZooKeeper upgrades from StatefulSets #10935

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Dec 10, 2024

Type of change

  • Task

Description

Strimzi 0.46 aims to support direct upgrades from Strimzi 0.39 or newer. This is because that is where the KRaft upgrades are supported. So as part of the Strimzi 0.46 release we can remove the logic for upgrading from StatefulSets to StrimziPodSets as the UseStrimziPodSets is GA from Strimzi 0.34. This PR removes this logic as well as the related code for managing StatefulSets as we now don't use StatefulSets anymore.

(The full documentation upgrade will be done later as part of the ZooKeeper support removal)

Checklist

  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.46.0 milestone Dec 10, 2024
@scholzj
Copy link
Member Author

scholzj commented Dec 10, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 10, 2024

/azp run zookeeper-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 10, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj marked this pull request as ready for review December 11, 2024 09:18
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Couple of suggestions

CHANGELOG.md Outdated Show resolved Hide resolved
scholzj and others added 2 commits December 17, 2024 14:33
@scholzj scholzj force-pushed the remove-Kafka-and-ZooKeeper-upgrade-from-StatefulSets branch from 7af034c to 90c0809 Compare December 17, 2024 13:53
@scholzj
Copy link
Member Author

scholzj commented Dec 17, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit 829a29a into strimzi:main Dec 17, 2024
21 checks passed
@scholzj scholzj deleted the remove-Kafka-and-ZooKeeper-upgrade-from-StatefulSets branch December 17, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 0.46.0 (Work In Progress)
Development

Successfully merging this pull request may close these issues.

4 participants