Avoid failing the CI pipelines on "special" commit messages #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e" this in the message Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
approved these changes
Dec 14, 2024
ppatierno
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Some commit messages with some special characters and structure might break the script that logs the variable values in out CI pipelines. (Unfortunately, one such message is generated when reverting GitHub PRs 🙄). An example of such message is the one used in this PR:
Where the combination of
(inside"causes the error:I did not found any way to automatically escape this in the Azure pipelines. So to avoid this, I marked the step that logs the variables to continue even on error. As it is logging step only, it should be fine and it will not block us in the future as it did with the 0.45.0-rc2.