Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ZooKeeper support - Part I #10964

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Dec 18, 2024

Type of change

  • Task

Description

This PR starts the removal of the ZooKeeper support from Strimzi. This initial part does the following:

  • Adds protection against damaging ZooKeeper-based clusters and operates only KRaft clusters
  • Removes most of ZooKeeper and migration from the cluster-operator module
  • Removes ZooKeeper and migration from the kafka-agent module
  • Removes ZooKeepers from the container image scripts
  • Disables the ZooKeeper-based upgrade tests

The focus of this PR is on removing the ZooKeeper & KRaft migration logic and the related dead code. The only really new code is the validation of the clusters that they are KRaft-based and throwing exceptions if not in the KafkaAssemblyOperator class (and the related unit tests).

This PR does not handle examples, api module, documentation, system tests and other parts of the code. That will be handled only in separate follow-up PRs.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.46.0 milestone Dec 18, 2024
@scholzj
Copy link
Member Author

scholzj commented Dec 18, 2024

/azp run upgrade

@scholzj
Copy link
Member Author

scholzj commented Dec 18, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj force-pushed the remove-zookeeper-support branch from 8cc3dd8 to 919ea2b Compare December 18, 2024 16:44
@scholzj
Copy link
Member Author

scholzj commented Dec 18, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 18, 2024

/azp run feature-gates-regression

@scholzj scholzj marked this pull request as ready for review December 18, 2024 22:33
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 19, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming all tests pass.

CHANGELOG.md Outdated Show resolved Hide resolved
@scholzj scholzj force-pushed the remove-zookeeper-support branch from 919ea2b to 00101be Compare December 20, 2024 16:19
@scholzj scholzj merged commit 7774ca8 into strimzi:main Dec 20, 2024
13 checks passed
@scholzj scholzj deleted the remove-zookeeper-support branch December 20, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 0.46.0 (Work In Progress)
Development

Successfully merging this pull request may close these issues.

3 participants