Store Kafka node certificates in separate Secrets #10967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katheris
force-pushed
the
certSecretPerBroker
branch
from
9bce375 to
478869b
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
There seems to be quite a lot of test failures. I don't think they necessarily indicate issues with the production code. But it looks like you would need to do some updates to the STs (or sync with @strimzi/system-test-contributors to have them done here). |
|
The implementation looks good to me but I will have another pass when STs are green. Thanks! |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@scholzj @ppatierno the regression and upgrade tests are now passing |
scholzj
reviewed
Jan 9, 2025
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ClusterCa.java
Show resolved
Hide resolved
scholzj
reviewed
Jan 9, 2025
systemtest/src/test/java/io/strimzi/systemtest/security/custom/CustomCaST.java
Show resolved
Hide resolved
documentation/modules/security/ref-certificates-and-secrets.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/ref-list-of-kafka-cluster-resources.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/security/ref-certificates-and-secrets.adoc
Outdated
Show resolved
Hide resolved
...t/java/io/strimzi/operator/cluster/operator/assembly/KafkaAssemblyOperatorKRaftMockTest.java
Show resolved
Hide resolved
...r-operator/src/test/java/io/strimzi/operator/cluster/operator/assembly/CaReconcilerTest.java
Outdated
Show resolved
Hide resolved
...er-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaReconciler.java
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java
Show resolved
Hide resolved
tinaselenge
reviewed
Jan 13, 2025
...er-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaReconciler.java
Outdated
Show resolved
Hide resolved
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
katheris
force-pushed
the
certSecretPerBroker
branch
from
65aadd4 to
e905a54
Compare
Signed-off-by: Katherine Stanley <[email protected]>
|
/azp run regression |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
tinaselenge
approved these changes
Jan 14, 2025
|
@katheris Should we merge it? Or do you want to wait for @ppatierno? |
|
@katheris please wait it's on my to-do list for tomorrow morning. Thanks! |
ppatierno
approved these changes
Jan 15, 2025
...er-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaReconciler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Katherine Stanley <[email protected]>
|
@ppatierno @scholzj @tinaselenge FYI I pushed one last change to make the |
|
@katheris You can merge this, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Store Kafka node certificates in separate Secrets rather than in a single shared Secret.
This addresses issue #7687
Checklist
Please go through this checklist and make sure all applicable tasks have been done