Fixed check Optional not null

[ppatierno]

While reviewing a TO related PR I came across the following code which I think is "wrong":

if (configChanges != null && configChanges.isEmpty()) {
                LOGGER.debugCr(reconcilableTopic.reconciliation(), "Config changes {}", configChanges);
            } else {
                LOGGER.debugCr(reconcilableTopic.reconciliation(), "No config change");
            }

I see a couple of issues here:

• the configChanges != null is not needed because it's always true. The configChanges is an Optional coming from a findFirst() on a stream which always returns an Optional which can be empty or not but never a null.
• the logging seems to be in the opposite order. If empty logs the config changes, if not empty logs "no config change".

[ppatierno]

@fvaleri as TO expert, what do you think about this? If that's ok with you I will run regression tests.

[fvaleri]

You just forgot to call get, otherwise LGTM.
Thanks for catching this.

[ppatierno]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[fvaleri]

LGTM. Thanks.