Remove the external service name method from KafkaResources
#11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
im-konge
approved these changes
Jan 10, 2025
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Jan 10, 2025
ppatierno
approved these changes
Jan 10, 2025
scholzj
deleted the
remove-external-service-name-method-from-kafka-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
externalBootstrapServiceNamein theKafkaResourcesclass is a relict from the times long gone as we do not have any special external service now (all listeners are named by the user and have their own types). It should not be in theKafkaResourcesclass that is in the API (it was also used in tests only anyway). This PR removes it.Checklist