Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for storage class overrides #11034

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Jan 14, 2025

Type of change

  • Task

Description

This PR implements the second part of the SP-080 proposal -> it removes support for the storage overrides that allow specifying different storage classes for different nodes.

With this PR:

  • For new clusters:
    • Any storage class overrides that are specified in the KafkaNodePool resources will be ignored and only rthe StorageClass configuration from the persistent volume configuration itself will be used
    • The following warnings will be added to resource conditions:
        - lastTransitionTime: "2025-01-14T14:42:47.398728342Z"
          message: In resource KafkaNodePool(myproject/aston) in API version kafka.strimzi.io/v1beta2
            the overrides property at path spec.storage.volumes.overrides has been deprecated.
            The storage overrides for individual brokers are not supported anymore since
            Strimzi 0.46.0.
          reason: DeprecatedFields
          status: "True"
          type: Warning
      as well as printed in the log:
      2025-01-14 14:46:47 WARN  StatusUtils:106 - Reconciliation #10(timer) Kafka(myproject/my-cluster): In resource KafkaNodePool(myproject/aston) in API version kafka.strimzi.io/v1beta2 the overrides property at path spec.storage.volumes.overrides has been deprecated. The storage overrides for individual brokers are not supported anymore since Strimzi 0.46.0.
      
  • For existing clusters:
    • The same conditions / warnings will be used as for new clusters
    • Any existing PVCs using the storage class from the overrides will be kept and used (We do not patch the storage class or support storage class changes, so they will remain untouched by Strimzi)
    • Any new PVCs created with this configuration under Strimzi 0.46.0 or newer will ignore the overrides and use the storage class directly from the persistent storage configuraton. So e.g. when scaling up, the PVCs for the new nodes will ignore the overrides. Similarly, when the old PVCs with the storage class from the override is deleted and the operator creates a new PVC, the overrides will be ignored.

Users who want this feature should instead have different node pools that use different storage classes each.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.46.0 milestone Jan 14, 2025
@scholzj scholzj requested a review from ppatierno January 14, 2025 15:19
@scholzj
Copy link
Member Author

scholzj commented Jan 14, 2025

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Scholz <[email protected]>
@scholzj scholzj merged commit feb51b6 into strimzi:main Jan 16, 2025
13 checks passed
@scholzj scholzj deleted the remove-support-for-storage-class-overrides branch January 16, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants