Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(kraft): cleans up the docs for out-of-date descriptions relating to KRaft #11071

Merged
merged 2 commits into from
Jan 24, 2025
Merged

docs(kraft): cleans up the docs for out-of-date descriptions relating to KRaft #11071

merged 2 commits into from
Jan 24, 2025

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Jan 23, 2025 •
edited
Loading

Documentation

Edits to the docs to remove or amend content relating to the permanent switch to KRaft

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.46.0 milestone Jan 23, 2025
@PaulRMellor PaulRMellor self-assigned this Jan 23, 2025
ppatierno
ppatierno approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

katheris
katheris approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katheris katheris self-requested a review January 23, 2025 15:09
@katheris
Copy link
Contributor

@PaulRMellor looks like you need to commit the update Helm chart files. Otherwise it looks good to me

scholzj
scholzj approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the comment from Kate.

@PaulRMellor
Copy link
Contributor Author

Thanks for reviews. Added the helm charts.
Not sure why they weren't rebuilt first time

@scholzj scholzj merged commit 0afa532 into strimzi:main Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppatierno ppatierno ppatierno approved these changes

@scholzj scholzj scholzj approved these changes

@katheris katheris Awaiting requested review from katheris

Assignees

@PaulRMellor PaulRMellor

Labels
None yet
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulRMellor @katheris @scholzj @ppatierno