Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: github actions #1248

Merged
merged 2 commits into from
Mar 3, 2021
Merged

CI: github actions #1248

merged 2 commits into from
Mar 3, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Feb 13, 2021 •
edited
Loading

r? @ob-stripe
Introduces github actions for CI.

  • skips goveralls
  • skips testing on "tip" which isn't supported (yet) by the setup-go action: Support tip? actions/setup-go#21
    • Unfortunately GHA seems to lack an exact analog to "allowed failures" in Travis, so testing on tip wouldn't really work as desired anyway.

Also fixes some linter errors. Travis isn't failing when golint fails, for some reason, and so there were some lingering lint problems that need to be fixed.

@richardm-stripe richardm-stripe force-pushed the richardm-gha branch 4 times, most recently from 8e2781e to ae2fdaf Compare March 3, 2021 21:11
@richardm-stripe richardm-stripe changed the title [WIP] CI: github actions CI: github actions Mar 3, 2021
ob-stripe
ob-stripe suggested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.16 was released a couple weeks ago so we should start testing it.

Also it looks like you've got an unrelated file that snuck into your PR.

@richardm-stripe
Copy link
Contributor Author

r? @ob-stripe
Added 1.16! The extra file is a real fix -- Travis isn't failing properly on the "lint" step, although I could commit that separately if you'd like.

@richardm-stripe richardm-stripe removed their assignment Mar 3, 2021
ob-stripe
ob-stripe approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, lgtm!

@richardm-stripe richardm-stripe merged commit 4bc428a into master Mar 3, 2021
@richardm-stripe richardm-stripe deleted the richardm-gha branch March 3, 2021 22:33
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
@jmather-c
Fix customer label changing to account (#1248)
a5c6b63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @ob-stripe