-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/2] Swift Concurrency migration - Financial Connections API client #4444
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a94eb39
Add FinancialConnectionsAsyncAPIClient
mats-stripe 1427460
Add and use FinancialConnectionsAPIClientFacade
mats-stripe b0260cd
Add toggle in example app to use async API client
mats-stripe 650889e
Add unit tests
mats-stripe 42eacc7
Fix dependencies and minor cleanup
mats-stripe 5dd3a7f
Remove Facade in favour of existential type
mats-stripe b81d579
Use user defaults instead of elements session context, update signup API
mats-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,7 @@ | |
460C7685096AA6C693309647 /* FinancialConnectionsAuthSession.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5C837C27C2577391B91FF0E5 /* FinancialConnectionsAuthSession.swift */; }; | ||
465AE8A58AD2183E1E2042FE /* ConsentDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = 81304AD5BE5CCA10D1A866E0 /* ConsentDataSource.swift */; }; | ||
486E50E6CB90208AB98C031E /* UIImageView+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = DDC3AC48492FAB61E5B66D94 /* UIImageView+Extensions.swift */; }; | ||
490A37E72D2EF6B0007917CD /* FinancialConnectionsSynchronize.json in Resources */ = {isa = PBXBuildFile; fileRef = 490A37E62D2EF6B0007917CD /* FinancialConnectionsSynchronize.json */; }; | ||
490B00112C93582900B1A489 /* FinancialConnectionsAccountPickerPane.swift in Sources */ = {isa = PBXBuildFile; fileRef = 490B00102C93582900B1A489 /* FinancialConnectionsAccountPickerPane.swift */; }; | ||
492039952CA4972B00CE2072 /* FinancialConnectionsWebFlowTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 492039942CA4972B00CE2072 /* FinancialConnectionsWebFlowTests.swift */; }; | ||
492651662C24C9E7001DDBCA /* TestModeAutofillBannerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 492651652C24C9E7001DDBCA /* TestModeAutofillBannerView.swift */; }; | ||
|
@@ -71,6 +72,8 @@ | |
49C9113B2C59932300589E0D /* LinkSignupFormView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 49C9113A2C59932300589E0D /* LinkSignupFormView.swift */; }; | ||
49F047532C63B430006BAD3E /* StripeSchemeAddress.swift in Sources */ = {isa = PBXBuildFile; fileRef = 49F047522C63B430006BAD3E /* StripeSchemeAddress.swift */; }; | ||
49F047552C63C2E5006BAD3E /* FinancialConnectionsPaymentDetails.swift in Sources */ = {isa = PBXBuildFile; fileRef = 49F047542C63C2E5006BAD3E /* FinancialConnectionsPaymentDetails.swift */; }; | ||
49F1B83A2D2DAE7100136303 /* FinancialConnectionsAsyncAPIClient.swift in Sources */ = {isa = PBXBuildFile; fileRef = 49F1B8392D2DAE7100136303 /* FinancialConnectionsAsyncAPIClient.swift */; }; | ||
49F1B83E2D2EC82300136303 /* FinancialConnectionsAsyncAPIClient+Legacy.swift in Sources */ = {isa = PBXBuildFile; fileRef = 49F1B83D2D2EC82300136303 /* FinancialConnectionsAsyncAPIClient+Legacy.swift */; }; | ||
4A0D015C978BD79BBFE6CE57 /* ManualEntryDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = BD4C39F5F9AF440B13F51A81 /* ManualEntryDataSource.swift */; }; | ||
4A537AE0C50CAFF3889EFE28 /* UIViewController+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = BF7E41313B709F87B549D85F /* UIViewController+Extensions.swift */; }; | ||
4DC8EB63806434ABF4C9CC43 /* [email protected] in Resources */ = {isa = PBXBuildFile; fileRef = 782A419DCF59BE6AB6439D04 /* [email protected] */; }; | ||
|
@@ -318,6 +321,7 @@ | |
452989E2D269784006EFD18C /* FinancialConnectionsPartnerAccount.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FinancialConnectionsPartnerAccount.swift; sourceTree = "<group>"; }; | ||
463549CECD379484842033E3 /* AccountPickerAccountLoadErrorView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AccountPickerAccountLoadErrorView.swift; sourceTree = "<group>"; }; | ||
4667E3861CDEC3A41B757714 /* FinancialConnectionsSynchronize.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FinancialConnectionsSynchronize.swift; sourceTree = "<group>"; }; | ||
490A37E62D2EF6B0007917CD /* FinancialConnectionsSynchronize.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = FinancialConnectionsSynchronize.json; sourceTree = "<group>"; }; | ||
490B00102C93582900B1A489 /* FinancialConnectionsAccountPickerPane.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FinancialConnectionsAccountPickerPane.swift; sourceTree = "<group>"; }; | ||
492039942CA4972B00CE2072 /* FinancialConnectionsWebFlowTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FinancialConnectionsWebFlowTests.swift; sourceTree = "<group>"; }; | ||
492651652C24C9E7001DDBCA /* TestModeAutofillBannerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TestModeAutofillBannerView.swift; sourceTree = "<group>"; }; | ||
|
@@ -333,6 +337,8 @@ | |
49C9113A2C59932300589E0D /* LinkSignupFormView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = LinkSignupFormView.swift; path = StripeFinancialConnections/Source/Native/NetworkingLinkSignupPane/LinkSignupFormView.swift; sourceTree = SOURCE_ROOT; }; | ||
49F047522C63B430006BAD3E /* StripeSchemeAddress.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StripeSchemeAddress.swift; sourceTree = "<group>"; }; | ||
49F047542C63C2E5006BAD3E /* FinancialConnectionsPaymentDetails.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FinancialConnectionsPaymentDetails.swift; sourceTree = "<group>"; }; | ||
49F1B8392D2DAE7100136303 /* FinancialConnectionsAsyncAPIClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FinancialConnectionsAsyncAPIClient.swift; sourceTree = "<group>"; }; | ||
49F1B83D2D2EC82300136303 /* FinancialConnectionsAsyncAPIClient+Legacy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "FinancialConnectionsAsyncAPIClient+Legacy.swift"; sourceTree = "<group>"; }; | ||
4A7B146AA6BF44921A249DB8 /* EmptyFinancialConnectionsAPIClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EmptyFinancialConnectionsAPIClient.swift; sourceTree = "<group>"; }; | ||
4AFBF95DAE0783010A17EB58 /* FinancialConnectionsSession_only_accounts.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = FinancialConnectionsSession_only_accounts.json; sourceTree = "<group>"; }; | ||
4BFCD9C339634B71FC8F85E9 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist; path = Info.plist; sourceTree = "<group>"; }; | ||
|
@@ -649,6 +655,8 @@ | |
FF54EDA6123C7E4E78D9D56B /* APIPollingHelper.swift */, | ||
2D95E5F34BDEE0237F52DA0A /* APIVersion.swift */, | ||
4E2EAD7059FF8358E674774A /* FinancialConnectionsAPIClient.swift */, | ||
49F1B8392D2DAE7100136303 /* FinancialConnectionsAsyncAPIClient.swift */, | ||
49F1B83D2D2EC82300136303 /* FinancialConnectionsAsyncAPIClient+Legacy.swift */, | ||
); | ||
path = "API Bindings"; | ||
sourceTree = "<group>"; | ||
|
@@ -910,6 +918,7 @@ | |
4AFBF95DAE0783010A17EB58 /* FinancialConnectionsSession_only_accounts.json */, | ||
1DF07A1AAD6B39033F0B86FD /* FinancialConnectionsSession_only_both_missing.json */, | ||
AA01BC4016BF8788633CCAD9 /* FinancialConnectionsSession_only_la.json */, | ||
490A37E62D2EF6B0007917CD /* FinancialConnectionsSynchronize.json */, | ||
); | ||
path = MockData; | ||
sourceTree = "<group>"; | ||
|
@@ -1230,6 +1239,8 @@ | |
"zh-Hant", | ||
); | ||
mainGroup = 7879CBA341D7E807714A831B; | ||
packageReferences = ( | ||
); | ||
productRefGroup = 820BF9CF057CF92872BC3C15 /* Products */; | ||
projectDirPath = ""; | ||
projectRoot = ""; | ||
|
@@ -1246,6 +1257,7 @@ | |
buildActionMask = 2147483647; | ||
files = ( | ||
D0C1EF46A418A8F8774B7418 /* FinancialConnectionsSession_both_accounts_la.json in Resources */, | ||
490A37E72D2EF6B0007917CD /* FinancialConnectionsSynchronize.json in Resources */, | ||
07BFA34C5643A79E1E35A159 /* FinancialConnectionsSession_only_accounts.json in Resources */, | ||
A156FACA60231988F247F6F4 /* FinancialConnectionsSession_only_both_missing.json in Resources */, | ||
ACD21F21C6E42706A882A1AE /* FinancialConnectionsSession_only_la.json in Resources */, | ||
|
@@ -1374,6 +1386,7 @@ | |
3446145FCA3278D51A9D4B80 /* AttachLinkedPaymentAccountDataSource.swift in Sources */, | ||
E3F62D2F9C344A1178030E8E /* AttachLinkedPaymentAccountViewController.swift in Sources */, | ||
707C265C4179A8FEC98913FE /* ConsentBodyView.swift in Sources */, | ||
49F1B83E2D2EC82300136303 /* FinancialConnectionsAsyncAPIClient+Legacy.swift in Sources */, | ||
465AE8A58AD2183E1E2042FE /* ConsentDataSource.swift in Sources */, | ||
97C528CE821C6A55D58F68A4 /* ConsentFooterView.swift in Sources */, | ||
8927328EE28A0C94B5AB69DB /* ConsentLogoView.swift in Sources */, | ||
|
@@ -1384,6 +1397,7 @@ | |
44203505ED2F64D07632566B /* LinkAccountPickerBodyView.swift in Sources */, | ||
6A13B9822B48BD6C00FFA327 /* AccountPickerRowView.swift in Sources */, | ||
C55F79F4B85E1EB8730B02C6 /* LinkAccountPickerDataSource.swift in Sources */, | ||
49F1B83A2D2DAE7100136303 /* FinancialConnectionsAsyncAPIClient.swift in Sources */, | ||
166ACB3BF53BDB4443E276E3 /* LinkAccountPickerFooterView.swift in Sources */, | ||
F0495231F4C70E054149C03A /* LinkAccountPickerNewAccountRowView.swift in Sources */, | ||
72BB9389206F10DE9B18E542 /* LinkAccountPickerViewController.swift in Sources */, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏