Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSE detection logic #430

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix SSE detection logic #430

merged 1 commit into from
Nov 21, 2023

Conversation

saucecontrol
Copy link
Contributor

As detailed in #411 (review), the current logic is completely broken.

This fixes it to match its intent, although this check probably belongs in the library CMakeLists where it's actually used if it's not going to be an option.

@farindk farindk merged commit 9393983 into strukturag:master Nov 21, 2023
22 of 24 checks passed
@farindk
Copy link
Contributor

farindk commented Nov 21, 2023

Thanks. I've moved this into the library directory and removed the double negation.

@saucecontrol saucecontrol deleted the sse-fix branch November 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants