Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Carthage support #1

Closed
wants to merge 1 commit into from

Conversation

oflannabhra
Copy link

  • Added .xcodeproject to build a SwiftCoAP.framework
  • Added Cartfile
  • Changed CocoaAsyncSocket to dependency

Changes will need to be made to the README.md to include Carthage instructions

Also, we will need to check releases to make sure they are versioned correctly.

@oflannabhra
Copy link
Author

I haven't verified yet if this actually works. These are at least the first steps to making this available through Carthage. Potential changes that will still need to occur: integrating CI so that prebuilt versions can exist

@oflannabhra
Copy link
Author

@stuffrabbit could you review this?

@oflannabhra
Copy link
Author

@stuffrabbit any word on whether you can merge this?

@stuffrabbit
Copy link
Owner

Hi, sorry I forgot to answer..
I have no experience in Carthage, and therefore cannot verify your code. Unfortunately, I don't have the time to take care of this for now due to my involvement in other projects. I suggest we keep this feature in your fork for now until you find out that everything works as it is supposed to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants