-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Standard initialization for Incompressible flows using thermodynamic_pressure and the Inc_Temperature_init #2137
Changes from 5 commits
f21e9f4
4ad661a
5c4bb37
ecfe347
710b8c1
aa1e93a
d2ca719
0727f72
aa68bae
bef45c4
36827d4
9025377
6984f49
aa0682e
1f26c1e
f697ab8
9f3df7a
355a2dd
d7dde2f
ab68bab
3efb756
c3990ab
d28406a
57ca1b0
a3d8d59
8fee817
f43d403
c68989c
a34d6b7
84cd93f
b04ce49
c7225d3
3d2ecd8
3c97262
a9e0d01
0d25e77
cf973be
cd99fcf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1246,6 +1246,9 @@ void CConfig::SetConfig_Options() { | |
/* DESCRIPTION: default value for AIR */ | ||
addDoubleListOption("MU_CONSTANT", nMu_Constant, Mu_Constant); | ||
|
||
/*!\brief CONSTANT_DENSITY \n DESCRIPTION: Constant density for incompressible flows (1.2886 kg/m^3 by default) \ingroup Config*/ | ||
addDoubleOption("DENSITY_CONSTANT", Density_Constant, 1.2886); | ||
|
||
/*--- Options related to Sutherland Viscosity Model ---*/ | ||
|
||
/* DESCRIPTION: Sutherland Viscosity Ref default value for AIR SI */ | ||
|
@@ -1334,8 +1337,6 @@ void CConfig::SetConfig_Options() { | |
addDoubleOption("INC_VELOCITY_REF", Inc_Velocity_Ref, 1.0); | ||
/*!\brief INC_TEMPERATURE_REF \n DESCRIPTION: Reference temperature for incompressible flows with the energy equation (1.0 by default) \ingroup Config*/ | ||
addDoubleOption("INC_TEMPERATURE_REF", Inc_Temperature_Ref, 1.0); | ||
/*!\brief INC_DENSITY_INIT \n DESCRIPTION: Initial density for incompressible flows (1.2886 kg/m^3 by default) \ingroup Config*/ | ||
addDoubleOption("INC_DENSITY_INIT", Inc_Density_Init, 1.2886); | ||
/*!\brief INC_VELOCITY_INIT \n DESCRIPTION: Initial velocity for incompressible flows (1.0,0,0 m/s by default) \ingroup Config*/ | ||
vel_init[0] = 1.0; vel_init[1] = 0.0; vel_init[2] = 0.0; | ||
addDoubleArrayOption("INC_VELOCITY_INIT", 3, vel_init); | ||
|
@@ -3022,6 +3023,11 @@ void CConfig::SetConfig_Parsing(istream& config_buffer){ | |
newString.append("DYNAMIC_ANALYSIS is deprecated. Use TIME_DOMAIN instead.\n\n"); | ||
else if (!option_name.compare("SPECIES_USE_STRONG_BC")) | ||
newString.append("SPECIES_USE_STRONG_BC is deprecated. Use MARKER_SPECIES_STRONG_BC= (marker1, ...) instead.\n\n"); | ||
else if (!option_name.compare("INC_DENSITY_INIT")) | ||
newString.append( | ||
"INC_DENSITY_INIT is deprecated. The initial density is computed using the ideal gas law based on the " | ||
"THERMODYNAMICS_PRESSURE and INC_TEMPERATURE_INIT. For Using the FLUID_MODEL=CONSTANT_DENSITY, the " | ||
"constant density must be given using the following option DENSITY_CONSTANT.\n\n"); | ||
Comment on lines
+3054
to
+3057
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We just released a major version, we are not breaking backward compatibility for an important setting like this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, we can wait for a major version to implement a change in config option. But now, sometimes we use thermodynamic pressure and sometimes we use density (to compute thermodynamic pressure) and I think the inconsistency should be fixed at some point, and I think it should be fixed in this way. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not saying we cannot fix things, but the option needs to be deprecated more gracefully than this.
|
||
else { | ||
/*--- Find the most likely candidate for the unrecognized option, based on the length | ||
of start and end character sequences shared by candidates and the option. ---*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a test