Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore cleanup turbo functions #2155

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

EvertBunschoten
Copy link
Member

@EvertBunschoten EvertBunschoten commented Oct 31, 2023

Proposed Changes

Clean up the turbomachinery functions in CEulerSolver.cpp and apply SU2 coding rules.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@EvertBunschoten EvertBunschoten changed the title [WIP]Chore cleanup turbo functions Chore cleanup turbo functions Nov 1, 2023
@EvertBunschoten EvertBunschoten marked this pull request as ready for review November 1, 2023 12:06
@pcarruscag pcarruscag changed the base branch from master to develop November 5, 2023 11:06
SU2_CFD/src/solvers/CEulerSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CEulerSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CEulerSolver.cpp Outdated Show resolved Hide resolved
@pcarruscag
Copy link
Member

@joshkellyjak do you want to take a look too?

@joshkellyjak
Copy link
Contributor

Will have a look this week, thanks Evert!

@EvertBunschoten EvertBunschoten merged commit 5024b19 into develop Nov 17, 2023
30 checks passed
@EvertBunschoten EvertBunschoten deleted the chore_cleanup_turbo_functions branch November 17, 2023 06:46
@EvertBunschoten EvertBunschoten restored the chore_cleanup_turbo_functions branch November 17, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants