Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improvements #1

wants to merge 5 commits into from

Conversation

bgodlin
Copy link

@bgodlin bgodlin commented Jan 13, 2025

No description provided.

@bgodlin bgodlin marked this pull request as ready for review January 14, 2025 21:07
@bgodlin bgodlin requested a review from jamesbayly January 14, 2025 21:08
@stwiname
Copy link
Contributor

The DB and DB archive are here for integration tests. It is a submodule of https://github.com/subquery/subql-ai-app-framework/.

Please don't remove the DB

@jamesbayly
Copy link
Contributor

I'm unclear on what is being changed here. Can we split this up into a number of smaller changes that are more easily reviewed?

@bgodlin
Copy link
Author

bgodlin commented Feb 5, 2025

The DB and DB archive are here for integration tests. It is a submodule of https://github.com/subquery/subql-ai-app-framework/.

Please don't remove the DB

@stwiname if you’re using the submodule and running integration tests with a specific folder of the submodule, it might be worth considering updating the target to reflect the intention of separating the documentation tool from network-delegation-helper, as done in this commit b7b7418. If you agree, it might make sense to prepare a commit to update the integration tests and reference this PR so that both can be merged simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants