-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dictionary v2 poc update #221
Conversation
packages/node-core/src/indexer/blockDispatcher/block-dispatcher.ts
Outdated
Show resolved
Hide resolved
protected abstract buildDictionaryQueryEntries(dataSources: DS[]): DictionaryQueryEntry[]; | ||
protected abstract buildFatDictionaryQueryEntries(dataSources: DS[]): FatDictionaryQueryEntry; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to move this to the dictionary classes?
if (Array.isArray(dsOptions)) { | ||
const addresses = dsOptions.map((option) => option.address).filter(Boolean); | ||
|
||
if (addresses.length > queryAddressLimit) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be worth testing if we need this limit
…r.ts Co-authored-by: Scott Twiname <[email protected]>
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run failedFailed tests: 7/198. Failed suites: 11/42.
Report generated by 🧪jest coverage report action from 038e1c9 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist