Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): let event dates be timezone-independent #606

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sruenwg
Copy link
Collaborator

@sruenwg sruenwg commented Nov 5, 2024

Fixes half of #542.

This PR makes it so the displayed event dates are no longer dependent on user time zone.
E.g. if an event has date 2024-11-11T00:00:00Z, the event is listed as being on 2024-11-11 in all time zones.

spodule-event-date-no-tz-1.mp4

Regarding the rest of #542, I am unsure if we should apply the same change as above to site news items since, on second thought, I feel site news items do carry time information.
E.g. if the Discord bot was released on 2023-09-05T00:00:00Z, from the perspective of a user in Los Angeles, it might make more sense to say that the bot was released on 2023-09-04.
@sugar-cat7 Please let me know which you would prefer.

@sruenwg sruenwg requested a review from sugar-cat7 as a code owner November 5, 2024 03:02
Copy link

vercel bot commented Nov 5, 2024

@sruenwg is attempting to deploy a commit to the sugar-cat7's Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vspo-schedule ✅ Ready (Inspect) Visit Preview Nov 5, 2024 6:27am

@sugar-cat7
Copy link
Owner

Regarding the rest of #542, I am unsure if we should apply the same change as above to site news items since, on second thought, I feel site news items do carry time information.

@sruenwg
Personally, I think it would be better for site news items not to depend on the user’s time zone either. Like events, we round the display to 00:00:00, so making it dependent on time zones may not be ideal.

Copy link
Owner

@sugar-cat7 sugar-cat7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sruenwg
Copy link
Collaborator Author

sruenwg commented Nov 5, 2024

@sruenwg Personally, I think it would be better for site news items not to depend on the user’s time zone either. Like events, we round the display to 00:00:00, so making it dependent on time zones may not be ideal.

Sounds good, will raise a separate PR for that.

@sruenwg sruenwg merged commit d19c407 into sugar-cat7:main Nov 5, 2024
4 checks passed
@sruenwg sruenwg deleted the fix-no-tz-dates branch November 5, 2024 22:15
@sruenwg sruenwg linked an issue Nov 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Events and site news dates change depending on time zone
2 participants