Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): convert terms and privacy policy styling from SCSS to CSS-in-JS #681

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

sruenwg
Copy link
Collaborator

@sruenwg sruenwg commented Feb 6, 2025

Closes #212.

This PR moves the styles previously defined in styles/Terms.module.scss into a JS component to better align with the styling pattern used elsewhere in the codebase.
This means sass is no longer a dependency, so it has been removed.

The styling of the /terms and /privacy-policy pages should be exactly as before (as should all other pages in the app).

vspodule-remove-scss-modules.mov

@sruenwg sruenwg requested a review from sugar-cat7 as a code owner February 6, 2025 00:32
Copy link

vercel bot commented Feb 6, 2025

@sruenwg is attempting to deploy a commit to the sugar-cat7's Team Team on Vercel.

A member of the Team first needs to authorize it.

Repository owner deleted a comment from vercel bot Feb 6, 2025
Copy link
Owner

@sugar-cat7 sugar-cat7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@sruenwg sruenwg merged commit cdfac05 into sugar-cat7:main Feb 6, 2025
4 checks passed
@sruenwg sruenwg deleted the remove-scss branch February 6, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Remove SCSS modules
2 participants